docs: Fix Windows activation command and typo in CONTRIBUTING.md #3684
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @88448844, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
adk-bot
added
the
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a typo and corrects the virtual environment activation command for Windows in CONTRIBUTING.md. The changes are helpful for new contributors using Windows. I've provided one suggestion to further refine the Windows command for clarity.
The bot noticed that while source was correctly removed, the word shell itself also seems to be a formatting artifact and should be removed for clarity and easy C&P Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ryanaiagent
added
the
needs-review
|
Hi @88448844, Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @wyf7107 , can you please review this |
|
Hey, just wanted to know if the PR will be merged at some point? |
3 participants
Description of Change
While setting up the project on a Windows machine, I found that the command for activating the virtual environment in
CONTRIBUTING.mdwas incorrect. Thesourcecommand doesn't work on Windows (unless git bash), so I've also added.\.venv\Scripts\activate.I also fixed a small grammar typo ("a Issue" → "an Issue") in the same file.
These minor changes should make it a bit easier for new contributors on Windows to get started.
Testing Plan
This is a documentation fix, so no new unit tests are needed. I've confirmed the corrected activation command works on a Windows machine.
Checklist
CONTRIBUTING.mddocument.